v0.3.6: Addressing typo in permissions fix#81
Open
tkralj-1 wants to merge 2 commits intonetbox-community:masterfrom
Open
v0.3.6: Addressing typo in permissions fix#81tkralj-1 wants to merge 2 commits intonetbox-community:masterfrom
tkralj-1 wants to merge 2 commits intonetbox-community:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a typo in the
permission_requiredattribute (add_floorplano->add_floorplan).This typo prevented users with the correct
netbox_floorplan.add_floorplanpermission from being able to add new floorplans, causing an authorization error. (bug introduction PR). PR where this was fixed on main but did not get cut to a new release of v0.3.XMaintainer Instructions
This is a legacy patch for users on NetBox v3.7 and should NOT be merged into
main.Please create a new maintenance branch from the
v0.3.6tag and merge this branch's changes there to tag a newv0.3.7release.Changes Included: