Skip to content

Conversation

@M4itee
Copy link
Contributor

@M4itee M4itee commented Jan 23, 2026

Adding ability to get otel metrics from the kubernetes

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mateusz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds OpenTelemetry Collector integration to the Netdata Helm chart, enabling the collection of logs from Kubernetes pods and forwarding them to a netdata instance via OTLP protocol.

Changes:

  • Added netdataOpentelemetry deployment and service for receiving OTLP data
  • Integrated opentelemetry-collector as a subchart dependency for collecting Kubernetes logs
  • Fixed YAML indentation issues in ingress hosts and child tolerations configurations

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
charts/netdata/values.yaml Added netdataOpentelemetry configuration section and otel-collector subchart settings; fixed indentation issues
charts/netdata/templates/netdata-otel/service.yaml Created service to expose OTLP endpoint on port 4317
charts/netdata/templates/netdata-otel/secrets.yaml Created secrets template for OTEL configuration
charts/netdata/templates/netdata-otel/persistentvolumeclaim.yaml Created PVC for OTEL log storage
charts/netdata/templates/netdata-otel/deployment.yaml Created deployment for netdata instance with OTEL plugin enabled
charts/netdata/templates/netdata-otel/configmap.yaml Created configmap template for OTEL configuration
charts/netdata/templates/_helpers.tpl Added helper templates for netdataOpentelemetry configs management
charts/netdata/Chart.yaml Added opentelemetry-collector subchart dependency
charts/netdata/Chart.lock Generated lock file for subchart dependency
charts/netdata/charts/opentelemetry-collector-0.115.0.tgz Added OpenTelemetry Collector subchart package

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ilyam8
Copy link
Member

ilyam8 commented Jan 24, 2026

@cubic-dev-ai review this PR

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 10 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@witalisoft witalisoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure that otel is also enabled when we are running checks

@M4itee M4itee force-pushed the otel-collector-integration branch from c268d60 to f065b9d Compare January 30, 2026 13:54
@M4itee M4itee force-pushed the otel-collector-integration branch from f065b9d to ac92e27 Compare January 30, 2026 13:59
@M4itee M4itee force-pushed the otel-collector-integration branch from 5c3757b to 4b1dbb2 Compare January 30, 2026 14:28

The following table lists the configurable parameters of the netdata chart and their default values.

{{ template "chart.valuesTableHtml" . }}
Copy link
Contributor Author

@M4itee M4itee Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML because it renders better the multiline comments and values + adds some extra feats like copy, colors. Any markdown parser will render it no problem anyway.

- name: Run chart-testing (install)
run: ct install --target-branch ${{ github.event.repository.default_branch }}

- name: Run chart-testing (install with OpenTelemetry)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an extra for easier problem catching, in theory we can just use this one and delete the regular install. Good thing is that at the end of the ct install there is a cleanup so they are both independent.

@M4itee
Copy link
Contributor Author

M4itee commented Jan 30, 2026

Last thing left for now is to make docs a bit more readable, after that it should be ready for review

@M4itee M4itee force-pushed the otel-collector-integration branch 4 times, most recently from c4cc83f to 73258ee Compare January 30, 2026 17:13
@M4itee M4itee force-pushed the otel-collector-integration branch from 73258ee to 138f84e Compare January 30, 2026 17:16
@ilyam8 ilyam8 requested a review from Copilot January 30, 2026 18:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 14 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@M4itee M4itee force-pushed the otel-collector-integration branch 3 times, most recently from a15734d to 3a77eb2 Compare February 2, 2026 12:04
install steps in cheks now wait for resources, archive is no longer in
the branch - it is pulled during the tests and release.
@M4itee M4itee force-pushed the otel-collector-integration branch 3 times, most recently from abfbb32 to 8705505 Compare February 2, 2026 12:35
@M4itee M4itee force-pushed the otel-collector-integration branch from 8705505 to 436a9cc Compare February 2, 2026 12:35
@M4itee M4itee marked this pull request as ready for review February 2, 2026 14:15
@M4itee M4itee requested review from a team as code owners February 2, 2026 14:15
@M4itee M4itee requested review from ilyam8 and witalisoft February 2, 2026 14:15
@ilyam8 ilyam8 requested a review from Copilot February 2, 2026 15:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +32 to +35
- name: Set up Helm
uses: azure/setup-helm@v4
with:
version: v3.12.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is already included in the runner in newer version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants