Skip to content

feat: add setRequestToken and fetchRequestToken methods#900

Merged
susnux merged 3 commits intomainfrom
feat/settoken
Apr 14, 2026
Merged

feat: add setRequestToken and fetchRequestToken methods#900
susnux merged 3 commits intomainfrom
feat/settoken

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented Mar 3, 2026

Basically move them from server to this library, implementation only slightly changed for the non-dom case to keep service worker support. Otherwise same implementation and even tests are copied.

This allows us to have 1 place with the set token logic to reduce problems where the tokens get out of sync.

@susnux susnux requested review from ShGKme and artonge March 3, 2026 11:02
@susnux susnux added enhancement New feature or request 3. to review labels Mar 3, 2026
@susnux susnux force-pushed the feat/settoken branch 2 times, most recently from cfc893c to b7d9bc6 Compare March 3, 2026 11:05
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.00%. Comparing base (4d62736) to head (669418f).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lib/requestToken.ts 90.62% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   60.71%   70.00%   +9.28%     
==========================================
  Files           4        4              
  Lines          56       80      +24     
  Branches       17       23       +6     
==========================================
+ Hits           34       56      +22     
+ Misses         20       19       -1     
- Partials        2        5       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@susnux susnux requested a review from artonge March 3, 2026 12:38
@susnux susnux requested a review from ShGKme March 3, 2026 17:20
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 13, 2026

(rebased)

Copy link
Copy Markdown

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Copy link
Copy Markdown

@pringelmann pringelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just minor comment on subscription cleanup

Copy link
Copy Markdown

@cristianscheid cristianscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

susnux added 2 commits April 14, 2026 16:48
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/settoken branch 2 times, most recently from edf1b87 to 876728b Compare April 14, 2026 14:52
…JS limitations

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 74f572d into main Apr 14, 2026
9 checks passed
@susnux susnux deleted the feat/settoken branch April 14, 2026 14:57
@susnux susnux mentioned this pull request Apr 14, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants