feat: add setRequestToken and fetchRequestToken methods#900
Merged
Conversation
cfc893c to
b7d9bc6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
==========================================
+ Coverage 60.71% 70.00% +9.28%
==========================================
Files 4 4
Lines 56 80 +24
Branches 17 23 +6
==========================================
+ Hits 34 56 +22
+ Misses 20 19 -1
- Partials 2 5 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
artonge
reviewed
Mar 3, 2026
ShGKme
reviewed
Mar 3, 2026
ShGKme
reviewed
Mar 3, 2026
Contributor
Author
|
(rebased) |
pringelmann
reviewed
Apr 14, 2026
pringelmann
reviewed
Apr 14, 2026
pringelmann
reviewed
Apr 14, 2026
pringelmann
approved these changes
Apr 14, 2026
pringelmann
left a comment
There was a problem hiding this comment.
looks good, just minor comment on subscription cleanup
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
edf1b87 to
876728b
Compare
…JS limitations Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically move them from server to this library, implementation only slightly changed for the non-dom case to keep service worker support. Otherwise same implementation and even tests are copied.
This allows us to have 1 place with the
set tokenlogic to reduce problems where the tokens get out of sync.