fix(a11y): don't auto-open dropdown on focus, hide decorative chevron#73
Open
pringelmann wants to merge 1 commit intomainfrom
Open
fix(a11y): don't auto-open dropdown on focus, hide decorative chevron#73pringelmann wants to merge 1 commit intomainfrom
pringelmann wants to merge 1 commit intomainfrom
Conversation
Tabbing into the search input used to auto-open the dropdown, jumping the screen reader into the listbox before the field name is announced (WCAG 3.2.1). The chevron also exposed a useless "Options list" name via aria-labelledby (WCAG 4.1.2). Mark it aria-hidden and drop the focus side-effect. Space/Enter/ArrowDown still open the dropdown. Refs: nextcloud-gmbh/customer-feature-requests#1587 -e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 91.31% 91.29% -0.02%
==========================================
Files 10 10
Lines 449 448 -1
Branches 145 146 +1
==========================================
- Hits 410 409 -1
Misses 33 33
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
susnux
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two WCAG findings on the combobox reported against the use management "New Account" dialog (nextcloud-gmbh/customer-feature-requests#1587).
aria-labelledby. It'stabindex="-1"and the combobox input already exposes the open state, so it's purely decorative. Marked itaria-hidden="true"and dropped remaining aria tags. Mouse users still get the click target.Behavior changes
Worth a minor bump, not a patch:
aria-labelledby/aria-controls/aria-expandedon the button will break.No props, events, or methods changed.
Follow-ups
Once released:
nextcloud-vue: migrateNcSelectonmainfrom upstreamvue-selectback to@nextcloud/vue-select, bump to this versionserver: bump@nextcloud/vue