Skip to content

Fix: Prevent re-requesting approval for already approved files #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasdotcom merged 2 commits into from
Apr 6, 2026
Merged

Fix: Prevent re-requesting approval for already approved files #399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
429b073
Fix: Prevent re-requesting approval for already approved files
Amitdwivedi22 Mar 17, 2026
d4255a6
Fix feedback
lukasdotcom Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/Service/ApprovalService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,9 @@ public function request(int $fileId, int $ruleId, ?string $userId, bool $createS
}

if ($this->userIsAuthorizedByRule($userId, $rule, 'requesters')) {
if ($this->tagObjectMapper->haveTag((string)$fileId, 'files', $rule['tagApproved'])) {
return ['error' => $this->l10n->t('Approval has already been granted with this rule for this file')];
}
// only request if it has not yet been requested for this rule
if (!$this->tagObjectMapper->haveTag((string)$fileId, 'files', $rule['tagPending'])) {
if ($createShares) {
Expand Down
Loading