Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
chore/fix-lint-warnings
branch
from
83093f9 to
4209437
Compare
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve various lint warnings across the Vue UI and utility/store/service code by adjusting component options (e.g., emits), removing unused props/refs, and improving JSDoc annotations.
Changes:
- Add
emitsdeclarations to multiple Vue components and remove some unused props/refs. - Update templates/imports to address lint warnings (e.g., additional imports/registrations).
- Improve JSDoc parameter/return descriptions across several JS/TS files.
Reviewed changes
Copilot reviewed 39 out of 41 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/ReadOnlyContactDetails.vue | Replaces v-html usage and removes an unused prop. |
| src/views/Processing/ImportView.vue | Declares emitted events. |
| src/views/Processing/AddToGroupView.vue | Declares emitted events. |
| src/views/Contacts.vue | Adds/ registers UserGroupContent. |
| src/utils/matchTypes.ts | Improves JSDoc param descriptions. |
| src/utils/matchTypes.d.ts | Improves JSDoc param descriptions. |
| src/utils/addressbookUtils.js | Improves JSDoc param/return descriptions. |
| src/store/contacts.js | Refines JSDoc for action/mutation parameters and return. |
| src/store/circles.js | Refines JSDoc for action parameters. |
| src/store/addressbooks.js | Refines JSDoc for mutations/actions and returns. |
| src/services/validate.js | Adds clearer JSDoc for validation entrypoint. |
| src/services/circles.ts | Refines JSDoc params/returns. |
| src/services/circles.d.ts | Refines JSDoc formatting in declaration file. |
| src/models/member.ts | Improves constructor JSDoc param descriptions. |
| src/models/circle.ts | Improves method/constructor JSDoc param descriptions. |
| src/components/Properties/PropertyTitle.vue | Adds default for bus prop. |
| src/components/Properties/PropertyText.vue | Removes value prop declaration. |
| src/components/Properties/PropertySelect.vue | Removes value prop declaration. |
| src/components/Properties/PropertyMultipleText.vue | Renames v-for loop variable. |
| src/components/Properties/PropertyGroups.vue | Removes unused prop and declares emits. |
| src/components/Properties/PropertyDateTime.vue | Declares emits. |
| src/components/Properties/PropertyActions.vue | Declares emits. |
| src/components/OrgChart.vue | Disables an eslint rule at file level. |
| src/components/MemberList/MemberListItem.vue | Adds missing component import/registration. |
| src/components/MemberList/MemberList.vue | Adds missing icon import/registration. |
| src/components/EntityPicker/NewCircleIntro.vue | Declares emits. |
| src/components/EntityPicker/EntityPicker.vue | Removes a prop, changes a default, declares emits. |
| src/components/EntityPicker/EntityBubble.vue | Declares emits. |
| src/components/DetailsHeader.vue | Removes unused ref. |
| src/components/ContactsList/Merging.vue | Declares emits. |
| src/components/ContactDetails/ContactDetailsProperty.vue | Removes an unused prop. |
| src/components/ContactDetails/ContactDetailsAvatar.vue | Declares emits. |
| src/components/ContactDetails.vue | Replaces v-html, renames loop var, removes unused refs. |
| src/components/ConfirmationDialog.vue | Changes disabled default value. |
| src/components/CircleDetails.vue | Adjusts JSDoc escaping/type annotation. |
| src/components/ChartTemplate.vue | Removes unused prop. |
| src/components/AppNavigation/Settings/SettingsImportContacts.vue | Removes unused ref. |
| src/components/AppNavigation/GroupNavigationItem.vue | Declares emits, improves JSDoc. |
| src/components/AppNavigation/ContactsSettings.vue | Declares emits. |
| src/components/AppContent/ContactsContent.vue | Changes loading default and declares emits. |
| src/components/AppContent/CircleContent.vue | Changes loading default. |
Comments suppressed due to low confidence (1)
src/components/Properties/PropertySelect.vue:80
- The
valueprop was removed here, butPropertyMixinexpectsvalueto exist (it initializeslocalValue: this.valueand watchesvalue). This will break selection/value handling (includingv-model:value) unlessvalueis declared somewhere else (e.g. in the mixin).
props: {
hideActions: {
type: Boolean,
default: false,
},
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| </template> | ||
|
|
||
| <script> | ||
| /* eslint-disable vue/one-component-per-file */ |
Comment on lines
+260
to
+263
| * @param {object} context the store mutations current context | ||
| * @param {object} data destructuring object | ||
| * @param {Member} data.member the member to remove | ||
| * @param {boolean} data.leave whether to leave the circle instead of removing the member |
| }, | ||
| }, | ||
|
|
||
| emits: ['update:value'], |
Comment on lines
+75
to
76
| import UserGroupContent from '../components/AppContent/UserGroupContent.vue' | ||
| import RootNavigation from '../components/AppNavigation/RootNavigation.vue' |
| bus: { | ||
| type: Object, | ||
| required: false, | ||
| default: () => ({}), |
| <h6>{{ contact.fullName }}</h6> | ||
| <!-- Subtitle --> | ||
| <span v-html="formattedSubtitle" /> | ||
| <span :innerHTML="formattedSubtitle" /> |
| <template #subtitle> | ||
| <template v-if="isReadOnly"> | ||
| <span v-html="formattedSubtitle" /> | ||
| <span :innerHTML="formattedSubtitle" /> |
| internalSearch: { | ||
| type: Boolean, | ||
| default: true, | ||
| default: false, |
Comment on lines
166
to
171
| props: { | ||
| propName: { | ||
| type: String, | ||
| default: 'text', | ||
| }, | ||
|
|
||
| value: { | ||
| type: String, | ||
| required: true, | ||
| }, | ||
| }, |
| @@ -56,11 +56,6 @@ export default { | |||
| type: Object, | |||
| default: () => {}, | |||
| }, | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI generated,
I will open for review once I find time to review it myself