fix(updater): backport #9406 — respect autoUpdateCheck in Sparkle background checks#9705
Open
pedromdbl wants to merge 1 commit intonextcloud:stable-4.0from
Open
Conversation
pedromdbl
requested review from
Aiiaiiio,
camilasan,
i2h3,
mgallien and
nilsding
as code owners
Collaborator
|
@pedromdbl You need to rebase and correct your sign-off line which contains the wrong mail address. Otherwise this is fine. 🙂 |
i2h3
approved these changes
Mar 30, 2026
…ecks Backport of nextcloud#9406 to stable-4.0. The backgroundUpdateChecksAllowed delegate method only checked skipUpdateCheck() but ignored autoUpdateCheck(), causing Sparkle background update checks to always run regardless of the user's auto-update preference. This led to the update dialog appearing daily even after clicking "Install Update", as Sparkle's internal state machine became inconsistent. Similarly, backgroundCheckForUpdate() used !skipUpdateCheck() instead of autoUpdateCheck(). Fixes nextcloud#9704 Signed-off-by: Pedro Lino <pmdbl@sapo.pt>
mgallien
force-pushed
the
fix/backport-9406-sparkle-auto-update-check
branch
from
3957536 to
476f1b0
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9705.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #9406 to
stable-4.0.backgroundUpdateChecksAllowednow checks both!config.skipUpdateCheck()andconfig.autoUpdateCheck()before allowing Sparkle background update checksbackgroundCheckForUpdate()now usesconfig.autoUpdateCheck()instead of!ConfigFile().skipUpdateCheck()Without this fix, the Sparkle update dialog reappears daily on macOS even after the user clicks "Install Update", because the delegate creates an inconsistency in Sparkle 2's state management by not properly consulting the auto-update configuration.
Fixes #9704
Test plan
skipUpdateCheckinnextcloud.cfgstill prevents all update checks