Implement XDG Desktop Portal support#9727
Draft
FifthTundraG wants to merge 3 commits intonextcloud:masterfrom
Draft
Implement XDG Desktop Portal support#9727FifthTundraG wants to merge 3 commits intonextcloud:masterfrom
FifthTundraG wants to merge 3 commits intonextcloud:masterfrom
Conversation
Signed-off-by: FifthTundraG <117035030+FifthTundraG@users.noreply.github.com>
Signed-off-by: FifthTundraG <117035030+FifthTundraG@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a framework for adding XDP portals and implements the Background portal for proper autostart.
Fixes flathub/com.nextcloud.desktopclient.nextcloud#18
Related: flathub/com.nextcloud.desktopclient.nextcloud#225
CC @mgallien
This is a draft. There are a few considerations that still have to be made:
org.chromium.Chromium.desktopinstead ofcom.nextcloud.desktopclient.nextcloud.desktop. It wasn't occurring on c21ff3d, which is before what seems to be a settings page redesign (which I did not notice until merging newer changes lol), so it may be related to that? This also isn't very consistent, it happened once and now it's not anymore.USE_PORTALS) and make it configurable that way.Utility::hasLaunchOnStartupdoes not work (and has not worked) in a sandbox. Its usage ingeneralsettings.cppwas temporarily disabled, as it was preventingXdgPortal::backgroundfrom being run when the "run on startup" toggle was unchecked, which meant the autostart file was never removed.Please keep in mind that I'm quite new to C++ and insanely long buildscripts (lol), so please have grace on any silly mistakes :)