[stable-33.0] fix(macOS): Fix background update check incorrectly calling Sparkle when automaticallyChecksForUpdates is NO#9754
Merged
i2h3 merged 1 commit intostable-33.0from Mar 31, 2026
Conversation
…llyChecksForUpdates Fixes #9662 - Only checkForUpdatesInBackground when automaticallyChecksForUpdates Prevents calling -[SPUUpdater checkForUpdatesInBackground] when Sparkle's automaticallyChecksForUpdates is NO, which caused incorrect behavior and a Sparkle console warning (fixes #9662). Also refactors backgroundCheckForUpdate() into guard-style early returns so each condition produces its own precise log message. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
backportbot
bot
requested review from
i2h3,
mgallien and
nilsding
as code owners
backportbot
bot
added
bug
os: 🍎 macOS
nilsding
approved these changes
Mar 31, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #9744