chore(EventSource): drop no longer needed legacy fallback#59141
Merged
chore(EventSource): drop no longer needed legacy fallback#59141
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
approved these changes
Mar 21, 2026
Contributor
susnux
left a comment
There was a problem hiding this comment.
Agreed! Thank you very much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
OC\EventSourceclass has a legacy iframe-based fallback (dating back to ownCloud/IE9 era).The workaround was needed back in 2015 because older Microsoft browsers were in an awkward in-between state:
However:
EventSourceAPI has been supported in all browsers since IE was retired (Chrome 6+, Firefox 6+, Safari 5+, Edge 12+)UpdaterAdmin.vue->new OCEventSource(...)) which will work identically with native SSEuseFallBackproperty defaults tofalse, so on any modern browser the fallback was already never triggeredTODO
UpdaterAdmineventsource.js/OC.EventSourceoutright (only seems to be a trivial wrapper over nativeEventSource+ CSRF token and customdataobject handling)UpdaterAdmin.vueeasilyChecklist
3. to review, feature component)stable32)AI (if applicable)