test(cypress): improve resilience of files-copy-move sharing tests#59144
Draft
joshtrichards wants to merge 1 commit intomasterfrom
Draft
test(cypress): improve resilience of files-copy-move sharing tests#59144joshtrichards wants to merge 1 commit intomasterfrom
joshtrichards wants to merge 1 commit intomasterfrom
Conversation
- Remove `.within()` scoping to avoid stale DOM references on re-render
- Remove unused `cy.intercept()` calls (aliases were never awaited)
- Add explicit visibility gates before file picker interactions
- Re-query `.file-picker` per command chain for DOM freshness
- Add `CSS.escape()` to `moveFileForbidden` directory selector (bug fix)
- Increase assertion timeouts for slow CI environments
- Replace `cy.contains().should('not.exist')` anti-pattern with
`cy.get().should('not.contain')` for correct negative assertion
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the
files-copy-move.cy.tsCypress tests against flaky failures caused by DOM re-renders inside the file picker.Changes:
.within()scoping incopyFileForbiddenandmoveFileForbidden— the file picker can re-render during navigation, leaving.within()bound to a detached element. Each command now re-queries from the root.cy.intercept()calls — both helpers registered intercepts that were nevercy.wait()-ed on.cy.get('.file-picker').should('be.visible')before first interaction and after breadcrumb navigation.CSS.escape()inmoveFileForbiddendirectory selector, matching the existing pattern incopyFileForbidden.should('not.exist')anti-pattern —cy.contains(selector)must find an element before a chained.should('not.exist')can negate it, causing unnecessary full-timeout waits. Replaced withcy.get('.file-picker').should('not.contain', text).TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)