Skip to content

[stable33] fix(files_external): properly set default values for backend options #59397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
backportbot wants to merge 2 commits into
base: stable33
Choose a base branch
from
+10 −1
Draft

[stable33] fix(files_external): properly set default values for backend options #59397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2b8c44
fix(files_external): properly set default values for backend options
susnux Mar 31, 2026
b4ae97e
chore(assets): Recompile assets
nextcloud-command Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/files_external/src/components/AddExternalStorageDialog/BackendConfiguration.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@ const props = defineProps<{
watch(() => props.configuration, () => {
for (const key in props.configuration) {
if (!(key in modelValue.value)) {
modelValue.value[key] = props.configuration[key]?.type === ConfigurationType.Boolean
modelValue.value[key] = props.configuration[key]?.defaultValue ?? (props.configuration[key]?.type === ConfigurationType.Boolean
? false
: ''
)
}
}
}, { immediate: true })
Expand Down
8 changes: 8 additions & 0 deletions apps/files_external/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ export const ConfigurationType = Object.freeze({

export const ConfigurationFlag = Object.freeze({
None: 0,
/**
* Indicates that the configuration option is optional and can be left empty ("not required")
*/
Optional: 1,
UserProvided: 2,
Hidden: 4,
Expand Down Expand Up @@ -94,6 +97,11 @@ export interface IConfigurationOption {
* Optional tooltip for the configuration option
*/
tooltip?: string

/**
* Default value for the configuration option.
*/
defaultValue?: string | boolean
}

export interface IAuthMechanism {
Expand Down
Loading