feat(call): start 1-1 call from 'Talk to {person}' action#17205
Draft
feat(call): start 1-1 call from 'Talk to {person}' action#17205
Conversation
Antreesy
added
enhancement
feature: frontend 🖌️
Antreesy
force-pushed
the
feat/15416/call-from-anywhere
branch
3 times, most recently
from
4bf38f8 to
3d933c2
Compare
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
[skip ci] Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
[skip ci] Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
feat/15416/call-from-anywhere
branch
from
3d933c2 to
9185c55
Compare
| #[\Override] | ||
| public function getTitle(): string { | ||
| $visitingUser = $this->userSession->getUser(); | ||
| if (!$visitingUser || $visitingUser === $this->targetUser) { |
Member
There was a problem hiding this comment.
I already see this and getTarget getting out of sync with TalkAction.
but it feels it's too small to create an abstract class for it
| if ( | ||
| !$visitingUser | ||
| || $this->config->isDisabledForUser($this->targetUser) | ||
| || $this->config->isDisabledForUser($visitingUser) |
Member
There was a problem hiding this comment.
Should check if Limit starting a call is Disable calls in addition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Entry points:
Intermediate step (call here or in Talk) (🚧 WIP):
Call integration (🚧 WIP):
🚧 Tasks
🏁 Checklist
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required