feat(conversationfolder): use per share conversation folders#17346
Merged
miaulalala merged 2 commits intomainfrom Apr 8, 2026
Merged
feat(conversationfolder): use per share conversation folders#17346miaulalala merged 2 commits intomainfrom
miaulalala merged 2 commits intomainfrom
Conversation
miaulalala
commented
Mar 23, 2026
miaulalala
force-pushed
the
feat/4340/lazy-conversation-subfolders
branch
from
9f13642 to
270f200
Compare
|
Hi |
Contributor
Author
no not for now as that is quite a heavy process (depending on the number of users). But the old folder will still be accessible and all shares will stay as is in the chat, even if the conversation is renamed. |
nickvergessen
previously requested changes
Mar 26, 2026
Member
There was a problem hiding this comment.
Please check in the other sharing tests how to list folders and shares for users (e.g. https://github.com/nextcloud/spreed/pull/17483/changes) and add a the checks here to ensure the shares are stored with correct information for the actor and recipients
Member
There was a problem hiding this comment.
This here is also still missing, but we can do it in a follow up as well.
miaulalala
force-pushed
the
feat/4340/lazy-conversation-subfolders
branch
2 times, most recently
from
649496a to
2e1f1ce
Compare
miaulalala
added
the
feature: api 🛠️
miaulalala
force-pushed
the
feat/4340/lazy-conversation-subfolders
branch
2 times, most recently
from
23a7a8d to
7477c1c
Compare
miaulalala
force-pushed
the
feat/4340/lazy-conversation-subfolders
branch
from
7477c1c to
f410dae
Compare
miaulalala
commented
Apr 2, 2026
nickvergessen
approved these changes
Apr 8, 2026
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Since you need to resolve fixups anyway, lets simplify the boolean logic as well.
miaulalala
force-pushed
the
feat/4340/lazy-conversation-subfolders
branch
2 times, most recently
from
aa43380 to
11ae154
Compare
Introduces a per-share conversation subfolder scheme for Talk
attachments. Instead of a single flat attachment folder, files are
organised as:
Talk/<ConversationName>-<token>/<DisplayName>-<uid>/
A new POST /api/v1/chat/{token}/attachment endpoint accepts a file
path already inside the caller's conversation subfolder, creates a
folder-level TYPE_ROOM share (via ConversationFolderService) to give
all room members access, and posts the file_shared chat message.
The attachment folder root is configurable per user; the feature is
toggled via the `conversation_subfolders` app config key (default on)
and advertised through the existing capabilities mechanism.
AI-assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
…tion subfolder feature Covers ConversationFolderService (quota, share deduplication, rename-on-conflict), Share/Listener mount point resolution (flat, nested group/1-1 rooms, room-not-found fallback), SystemMessage parser for the fileId path, ChatController attachment endpoint, and the full sharing-1/conversation-folder integration suite. AI-assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
feat/4340/lazy-conversation-subfolders
branch
from
11ae154 to
fab2466
Compare
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required