fix(call): improve virtual background performance#17450
Draft
fix(call): improve virtual background performance#17450
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
b75813b to
873612b
Compare
11 tasks
- setting a size causes canvas 'reset' - not needed on every frame, only if size actually changes (input constraints) - low GPU impact Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- from camera FPS to min(camera, 25) FPS - mask lagging might be noticeable, but negligible - 10% less GPU consumed Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- add controls to tweak the values - AI-coded, as it's up to deletion. Worth keeping for debugging purposes? Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
873612b to
3291f0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Reduce GPU load while maintaining similar blur/mask quality and responsiveness
As refence - Zoom allows to login -> Meet -> Host a meeting -> Check your camera with virtual BG there.
AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Tested on Windows with Intel(R) UHD Graphincs
🚧 Tasks
🏁 Checklist