Open
Conversation
Koc
force-pushed
the
feature/apply-users-timezone
branch
2 times, most recently
from
e9c231b to
fd99a82
Compare
Member
|
I am not sure whether we should do this on the backend, or let the client decide what/how the date and time is being presented. Giving UTC leaves most flexibility to the web interface or any other client. No? |
Koc
force-pushed
the
feature/apply-users-timezone
branch
from
fd99a82 to
3b9b19e
Compare
Contributor
Author
|
indeed, I've changed approach. Now BE stores dates in UTC format without any transformations. At the same time FE handles:
Work still in progress, I'm testing various scenarios |
Koc
force-pushed
the
feature/apply-users-timezone
branch
from
11457bd to
098edb3
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/apply-users-timezone
branch
from
098edb3 to
e261963
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/apply-users-timezone
branch
from
e261963 to
90309b9
Compare
Member
Cool, let us know when it's there or when we can be of help. |
Contributor
Author
|
@blizzz more or less done, you can proceed with review and testing. I can't find any other places that should be adjusted. And we have green pipeline BTW 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now
createdAt/lastEditAtdisplays UTC timezone. This makes Tables module non-user friendly for a non-technical people who live not in England 😄 . With this PR BE will continue store dates in UTC format without any transformations. At the same time FE handles: