🖼️ Add persistent per-view layout modes (table / tiles / gallery)#2407
🖼️ Add persistent per-view layout modes (table / tiles / gallery)#2407
Conversation
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
|
@jancborchardt as new layouts will be relevant for your opinion |
jancborchardt
left a comment
There was a problem hiding this comment.
@marcoambrosini one for you, check it out. :)
@Rello do you have reference screenshots from Sharepoint as you mention?
List and Gallery view currently also look very similar (with Gallery in need of some design improvement).
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Refactor layout handling and improve preview URL generation logic. Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
|
@marcoambrosini can you please have a look now? the PR was now implemented and tested on the branch and I added the actual screenshots from the working app |
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Added 'layout' property with type and enum options. Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Updated layout property documentation to include default value and options. Signed-off-by: Rello <Rello@users.noreply.github.com>
There was a problem hiding this comment.
Hi @Rello, apologies for the late review
I think this is a nice addition, a few comments from the design perspective:
-
I don't think we should map the cards backgrounds and titles to the first columns of the table. Instead we could provide two select element in the settings below the view selection radio: "Background source" and " Title source", with the ability to select the right columns from there
-
Also in settings: instead of these radio buttons, let’s use our Nextcloud component
NcRadioGroupSo this:
Instead of this:
- The aspect ratio of the cards in gallery view is not very graceful visually, and they just grow uncontrolled if we adding many fields to them. We cannot make them scrollable because they are already within a scroll container, the page, and that would result in nested scrolling. To solve this I think we should remove the column names and limit the aspect ratio of the image to a 3:2 landscape orientation instead of 1:1. We would get something like this:
-
In gallery view, I would left align the title so that it matches the alignment of the text underneath
-
I’m not sure if it’s my screen, but it looks like the text in gallery view is blue. Let’s make sure it’s
--color-main-text
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>



Motivation
Tileis only showing the picture plus its title from the 2nd column. Use case: Index pagesGalleryview is showing all additional columns from the current view. Use case: Product catalogue or inventorytable,tilesandgalleryand have that preference stored with the view.table).Implementation
Source data
Tile View
Gallery View
Settings modal
Sharepoint reference