Fix: Make case-insensitive search for the usergroup and multi selection columns#2446
Open
Fix: Make case-insensitive search for the usergroup and multi selection columns#2446
Conversation
…on columns Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
bugfix/make-usergroup-selection-milti-filters-case-insensetiv
branch
from
a3b8def to
120718e
Compare
enjeck
reviewed
Apr 11, 2026
| } | ||
| }) | ||
| return ret | ||
| return ret.toLowerCase() |
Contributor
There was a problem hiding this comment.
Is it intentional that the search is case insentive but the other filters aren't?
For the Is equal / Is not equal operators. The filter UI stores whatever casing the user typed, so a row containing Alice now becomes alice before comparison. That makes Is equal "Alice" fail and Is not equal "Alice" incorrectly pass?
Comment on lines
+74
to
+75
| [FilterIds.Contains]() { return valueString?.toLowerCase().includes(filterValue.toLowerCase()) }, | ||
| [FilterIds.DoesNotContain]() { return !valueString?.toLowerCase().includes(filterValue.toLowerCase()) }, |
Contributor
There was a problem hiding this comment.
At https://github.com/nextcloud/tables/blob/main/src/shared/components/ncTable/partials/TableHeaderColumnOptions.vue#L315, there’s a small check meant to stop adding the same Contains or Does not contain filter twice. I think that conflicts with this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up for the #1798
☑️ Multi selection
👤 User single selection
👥 User multi selection