Skip to content

Fix: Properly display removed options in selection columns#2450

Open
Koc wants to merge 1 commit intomainfrom
bugfix/fix-displaying-removed-options
Open

Fix: Properly display removed options in selection columns#2450
Koc wants to merge 1 commit intomainfrom
bugfix/fix-displaying-removed-options

Conversation

@Koc
Copy link
Copy Markdown
Contributor

@Koc Koc commented Apr 6, 2026

Reproducer

  1. Create a table with select and multi select columns
  2. Create rows, select values
  3. Remove some options

Expected result

We should see yellow triangle with exclamation mark that informs us about non-existent optipns

🖼️ Screenshoots

➖ Before ➕ After
image image

@Koc Koc force-pushed the bugfix/fix-displaying-removed-options branch 5 times, most recently from 22960ea to d7f542a Compare April 6, 2026 11:37
@Koc Koc marked this pull request as ready for review April 6, 2026 11:38
@Koc Koc requested review from blizzz and enjeck as code owners April 6, 2026 11:38
@Koc Koc force-pushed the bugfix/fix-displaying-removed-options branch from d7f542a to 0d781c4 Compare April 10, 2026 21:22
@enjeck
Copy link
Copy Markdown
Contributor

enjeck commented Apr 11, 2026

Related to #727

Copy link
Copy Markdown
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If deleting an option is supposed to actually remove that value from rows, then the best UX in my opinion is to reflect that cleanup directly: remaining selections stay visible, deleted ones disappear. I don't like keeping a ghost value around.

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc Koc force-pushed the bugfix/fix-displaying-removed-options branch from 0d781c4 to 4aa1855 Compare April 12, 2026 21:29
@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants