Skip to content

📆 Show "Next meeting" in the chat#5865

Open
AndyScherzinger wants to merge 1 commit intomasterfrom
feat/5661/nextMeeting
Open

📆 Show "Next meeting" in the chat#5865
AndyScherzinger wants to merge 1 commit intomasterfrom
feat/5661/nextMeeting

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Feb 14, 2026


  • Resolves Show "Next meeting" in the chat #5661
  • Follows the implementation approach of the out-of-office feature
  • Reuses the scheduled-call feature data-formatting logic
  • Uses a generic copyright header, like we do in other non-mobile projects (can also switch to personal ones if you like)

🖼️ Screenshots

🕸️ Web 🏚️ Before 🏡 After
web before after

🚧 TODO

  • review & merge

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Feb 14, 2026
@AndyScherzinger AndyScherzinger changed the title Show "Next meeting" in the chat 📆 Show "Next meeting" in the chat Feb 14, 2026
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks different from the message pinning style as far as I can see? Or does it work well in conjunction with that?
#5807

2 floating boxes would be fine. Ideal could be one floating box with a horizontal divider line, to save on space and visual complexity.

@jancborchardt jancborchardt self-requested a review February 16, 2026 13:09
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind – saw #5867 just now :)

Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to already follow the suggestion from #5867 (comment) to make it collapsible?
Otherwise fine for me to do this in followup PRs.

@JsonField(name = ["location"])
var location: String,
@JsonField(name = ["calendarAppUrl"])
var calendarAppUrl: String
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now it fails with

2026-02-18 16:05:34.364 29876-29876 ChatActivity            com.nextcloud.talk2                  E  Error fetching upcoming events (Fix with AI)
                                                                                                    java.lang.NullPointerException: Parameter specified as non-null is null: method com.nextcloud.talk.models.json.upcomingEvents.UpcomingEvent.setCalendarAppUrl, parameter <set-?>
                                                                                                    	at com.nextcloud.talk.models.json.upcomingEvents.UpcomingEvent.setCalendarAppUrl(Unknown Source:2)
                                                                                                    	at com.nextcloud.talk.models.json.upcomingEvents.UpcomingEvent$$JsonObjectMapper.parseField(UpcomingEvent$$JsonObjectMapper.java:37)
                                                                                                    	at com.nextcloud.talk.models.json.upcomingEvents.UpcomingEvent$$JsonObjectMapper.parse(UpcomingEvent$$JsonObjectMapper.java:27)

please check which fields should be nullable.
see https://github.com/nextcloud/server/blob/a6d1fa1fa6f622f4036bdb9d5d9e2e83f99443f8/apps/dav/lib/CalDAV/UpcomingEvent.php

Copy link
Member Author

@AndyScherzinger AndyScherzinger Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, will do. I am seeing the definition while asking myself how they could be null no matter the spec. But oh well, seems they can 👍

All my events worked. Can you describe the event that fails for you, so I can test that case myself?

@AndyScherzinger
Copy link
Member Author

Would be nice to already follow the suggestion from #5867 (comment) to make it collapsible?
Otherwise fine for me to do this in followup PRs.

@mahibi Yes, I will simply change it according to the discussion on the other item 👍

Yet I am unsure if that means, hide it forever? hide until you open the chat again or hide it based on the date of the event you display?

WDYT @jancborchardt @nimishavijay ?

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet I am unsure if that means, hide it forever? hide until you open the chat again or hide it based on the date of the event you display?

Probably best would be to:

  • Always anyway show the "Upcoming call" box in the "Conversation info" view. Directly between conversation description and "Notification settings".
  • If you x away the "Upcoming call" box that shows directly in the conversation view, show a notice saying "Upcoming call can be viewed in conversation info".

Resolves #5661

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9898
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5865.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show "Next meeting" in the chat

3 participants

Comments