show diagnosis screen in english

[sowjanyakch]

fix #5823

🚧 TODO

• ...

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[AndyScherzinger]

@sowjanyakch translations vanish automatically over time if no stable branch ships the value string anymore, until then transifex will always bring them back (!). So you can ignore string values in value-* folders

[sowjanyakch]

@sowjanyakch translations vanish automatically over time if no stable branch ships the value string anymore, until then transifex will always bring them back (!). So you can ignore string values in value-* folders

@AndyScherzinger - the problem is eventhough I mark string as not translatable (with translatable = "false"), android still loads localised string because same string is already available in different languages. Without deleting strings, it is not possible to test the output. Happy to get some suggestions on how to improve the implementation.

Another reason to delete strings is increase in the warnings.

The resource string "nc_diagnose_signaling_mode_title" has been marked as translatable="false" elsewhere (usually in the values folder), but is translated to "sv" (Swedish) here

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5872.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	98	99
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	10	10
Dodgy code	54	54
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	81	81

Lint increased!

[AndyScherzinger]

Without deleting strings, it is not possible to test the output. Happy to get some suggestions on how to improve the implementation.

@sowjanyakch fine to leave them in in this case 👍 Given the files will get overwritten anyways after the first transifex sync, but that doesn't matter since it is merged.