Skip to content

conditionally handled fullscreen view of sharing manage #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
memurats merged 2 commits into from
Sep 3, 2025
Merged

conditionally handled fullscreen view of sharing manage #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
596c95a
conditionally handled fullscreen view of sharing manage
psawalka Sep 2, 2025
5d1f0a0
resolved lint errors
psawalka Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/actions/sharingPopupAction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,13 @@ export const action = new FileAction({
async exec(node, view, dir) {
// You need read permissions to see the sidebar
if ((node.permissions & Permission.READ) !== 0) {
setTimeout(() => {
const currentUrl = window.location.search

if (currentUrl.includes('popup')) {
document.querySelector('#app-sidebar-vue').style.width = '0%'
}
})
window.OCA.Files.Sidebar.close()

window.OCA.Files.Sidebar.setActiveTab('sharing-manage')
Expand Down
5 changes: 5 additions & 0 deletions src/components/OpenSharingButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ export default {
window.OCA.Files.Sidebar.setActiveTab('sharing')
window.OCA.Files.Sidebar.setFullScreenMode(true)

const currentUrl = window.location.search
if (!currentUrl.includes('openfile')) {
document.querySelector('#app-sidebar-vue').style.width = '0%'
}

// TODO: migrate Sidebar to use a Node instead
window.OCA.Files.Sidebar.open(fileInfoPathName)

Expand Down
10 changes: 8 additions & 2 deletions src/views/SharingPopup.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,12 +209,13 @@ export default {

closeThisModal() {
this.modal = false
const currentUrl = window.location.search

if (this.newLinkShare || this.shareSent) {
this.openSharingManage()
} else {
window.OCA.Files.Sidebar.close()
window.OCA.Files.Sidebar.setFullScreenMode(false)
currentUrl.includes('openfile') ? window.OCA.Files.Sidebar.setFullScreenMode(true) : window.OCA.Files.Sidebar.setFullScreenMode(false)
}
},

Expand All @@ -225,7 +226,12 @@ export default {
window.OCA.Files.Sidebar.close()
window.OCA.Files.Sidebar.setActiveTab('sharing')
window.OCA.Files.Sidebar.setActiveTab('sharing-manage')
window.OCA.Files.Sidebar.setFullScreenMode(false)
document.querySelector('#app-sidebar-vue').style.width = 'var(--app-sidebar-width)'

// set setfullscreen sidebar if opened in viewer else not
const currentSearch = window.location.search
const isTargetSearch = (currentSearch === '?dir=/' || currentSearch === '?dir=/&popup=true')
isTargetSearch ? window.OCA.Files.Sidebar.setFullScreenMode(false) : window.OCA.Files.Sidebar.setFullScreenMode(true)

// TODO: migrate Sidebar to use a Node instead
window.OCA.Files.Sidebar.open(fileInfoPathName)
Expand Down
Loading