[FIX NC30] Make getL10nFilesForApp() method public to support custom L10N in nmctheme#284
Open
[FIX NC30] Make getL10nFilesForApp() method public to support custom L10N in nmctheme#284
Conversation
memurats
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2025
… to support custom L10N factory in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
… to support custom L10N factory in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
… to support custom L10N factory in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Jun 30, 2025
… to support custom L10N factory in nmctheme
memurats
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
…pp() public to support custom L10N factory in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
…pp() public to support custom L10N factory in nmctheme
memurats
added
stable30
memurats
changed the title
memurats
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Aug 4, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Aug 8, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Aug 8, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Aug 14, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Sep 12, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
…ort custom L10N in nmctheme
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
…ort custom L10N in nmctheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Private method OC\L10N\Factory::getL10nFilesForApp() was not accessible from custom app nmctheme, causing a runtime error.
Solution: Changed the method visibility from private to public to allow controlled access from OCA\NMCTheme\L10N\FactoryDecorator.