Skip to content

Bugfix: convert keys to list#43

Closed
ChristophH wants to merge 1 commit intonf-core:devfrom
ChristophH:patch-1
Closed

Bugfix: convert keys to list#43
ChristophH wants to merge 1 commit intonf-core:devfrom
ChristophH:patch-1

Conversation

@ChristophH
Copy link
Copy Markdown

Fixes "AttributeError: 'dict_keys' object has no attribute 'index'" that occurred when using iGenomes GRCh38 Line 92 already wraps exon.keys() in list() - this seems to have been forgotten in line 199.

nf-core/slamseq pull request

Many thanks for contributing to nf-core/slamseq!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/slamseq branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).

Learn more about contributing: CONTRIBUTING.md

Fixes "AttributeError: 'dict_keys' object has no attribute 'index'" that occurred when using iGenomes GRCh38
Line 92 already wraps exon.keys() in list() - this seems to have been forgotten in line 199.
@lpantano
Copy link
Copy Markdown

lpantano commented Mar 5, 2026

Hi, I am closing this PR since is too old. Feel free to reopen with updated code to get the tests passing. Sorry we didn't get to merge on time.

@lpantano lpantano closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants