Skip to content

Add Icon dynamic#2827

Merged
jattasNI merged 39 commits intomainfrom
icon-dynamic
Feb 10, 2026
Merged

Add Icon dynamic#2827
jattasNI merged 39 commits intomainfrom
icon-dynamic

Conversation

@rajsite
Copy link
Copy Markdown
Member

@rajsite rajsite commented Jan 23, 2026

Pull Request

🤨 Rationale

Clients need a supported way to use custom icons in Nimble components. This change introduces the dynamic icon component so icons can be registered at runtime.

👩‍💻 Implementation

  • Added the dynamic icon component and registration.
  • Added Blazor helper/interop support for registration.
  • Added Storybook story and docs for usage.

🧪 Testing

  • Added unit tests to verify javascript helper method was called
  • Added ok component unit tests

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

Comment thread packages/blazor-workspace/Examples/Demo.Shared/Shared/MainLayout.razor.cs Outdated
Comment thread packages/blazor-workspace/Examples/Demo.Shared/wwwroot/Demo.Shared.lib.module.js Outdated
Base automatically changed from icon-refactor to main January 23, 2026 20:54
Comment thread packages/ok-components/src/icon-dynamic/index.ts
Comment thread packages/blazor-workspace/OkBlazor/Components/OkIconDynamic.cs Outdated
Comment thread packages/ok-components/src/icon-dynamic/index.ts Outdated
@hellovolcano hellovolcano marked this pull request as ready for review February 6, 2026 20:47
Copy link
Copy Markdown
Member Author

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hellovolcano looks good! I pushed some storybook doc tweaks and minor request to update the status table to include dynamic icon.
Ready to merge after @jattasNI gives it a lookover

Comment thread change/@ni-ok-blazor-92bc5855-6c34-423d-95b7-0263580eb28b.json
Comment thread packages/blazor-workspace/Examples/Demo.Shared/Pages/ComponentsDemo.razor Outdated
Comment thread packages/storybook/src/ok/icon-dynamic/icon-dynamic.stories.ts
Comment thread packages/storybook/src/ok/icon-dynamic/icon-dynamic.matrix.stories.ts Outdated
Comment thread packages/storybook/src/ok/icon-dynamic/icon-dynamic.matrix.stories.ts Outdated
@rajsite rajsite enabled auto-merge (squash) February 10, 2026 17:28
@jattasNI
Copy link
Copy Markdown
Contributor

Bypassing @msmithNI for OK Blazor change that already had input from @rajsite

@jattasNI jattasNI disabled auto-merge February 10, 2026 21:08
@jattasNI jattasNI merged commit ae64cd9 into main Feb 10, 2026
11 checks passed
@jattasNI jattasNI deleted the icon-dynamic branch February 10, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants