Open
Conversation
OliverCosma
approved these changes
Apr 8, 2026
jattasNI
reviewed
Apr 13, 2026
| gap: ${mediumPadding}; | ||
| } | ||
|
|
||
| .brand-icon { |
Contributor
There was a problem hiding this comment.
From screenshots of desktop and/or wireframes I thought I recalled this icon being big and multicolored rather than small and only black. I can confirm what's right at the UX meeting this Friday, but to start I'd suggest matching what desktop is doing:
- images (there's also a dark version)
- image sizing
From this PR
From Figma
Contributor
Author
There was a problem hiding this comment.
Added light and dark mode icons to icon-data.ts for now.
@jattasNI Do you think it would be better if I added them to nimble-tokens instead?
Alexia-Claudia-Micu
requested review from
mollykreis,
msmithNI and
rajsite
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
https://dev.azure.com/ni/DevCentral/_workitems/edit/3786413
Continuation of #2891
🤨 Rationale
Adding welcome message for Spright Chat Component, as defined in [Chat components]https://github.com/ni/nimble/blob/main/packages/spright-components/src/chat/specs/README.md)
👩💻 Implementation
🧪 Testing
Manual testing and added tests
✅ Checklist