Conversation
…elog-fix-python-3.8-details
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## master #2074 +/- ##
==========================================
- Coverage 91.33% 82.35% -8.99%
==========================================
Files 66 28 -38
Lines 16274 4001 -12273
==========================================
- Hits 14864 3295 -11569
+ Misses 1410 706 -704
Flags with carried forward coverage won't be shown. Click here to find out more. see 42 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Do not merge until after the 1.4.9 release. |
ni-jfitzger
left a comment
There was a problem hiding this comment.
The CHANGELOG has changed, since this PR was created. I'll need to pull main and recreate the change.
[ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Our CHANGELOG incorrectly stated that we added Python 3.8 support in both 1.1.4 and 1.2.0. In 1.2.0, we added the classifier to declare support on the PyPI page, because we neglected to do so in 1.1.4.
This change clarifies the 1.2.0 section of the CHANGELOG.
List issues fixed by this Pull Request below, if any.
None
What testing has been done?
PR Checks