Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
- Coverage 90.43% 90.36% -0.07%
==========================================
Files 4 4
Lines 1254 1277 +23
==========================================
+ Hits 1134 1154 +20
- Misses 106 108 +2
- Partials 14 15 +1
Continue to review full report at Codecov.
|
This adds a bitflag to the parser to enable parsing newlines as statement sentinels in place of semicolons. Semicolons continue to work. This still needs work to support a backslash before EOL as a means of ending a statement, but since there's no lookahead on tokens right now, that's a little tricky. Might be doable by checking if the last element of the current statement is a '\' word.
cad5a0c to
c8e65cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a bitflag to the parser to enable parsing newlines as
statement sentinels in place of semicolons. Semicolons continue to
work.
This still needs work to support a backslash before EOL as a means of
ending a statement, but since there's no lookahead on tokens right now,
that's a little tricky. Might be doable by checking if the last element
of the current statement is a '\' word.
Also, as-is, this requires that opening braces be on the same line as
the section they open. I don't see any reason to change this, so it'll
probably stick even if/when I add backslash line continuations.