Open
Conversation
Bug: _training_offloading_services_request() allocated 'pipeline' for deferred send but did not free it in the common cleanup path. Repeated requests leaked heap memory. Fix: free pipeline together with other temporary buffers in the error/done cleanup section. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Bug: _ml_service_training_offloading_process_received_data() overwrote receiver_pipe_json_str and trained_model_path without releasing previous allocations when multiple messages arrived. Fix: call g_clear_pointer() before assigning new duplicated/built strings. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Bug: _training_offloading_check_received_data() could overwrite received_thread with a new thread handle without joining the previous one, leaking thread resources across repeated start/check cycles. Fix: join and nullify an existing thread handle before creating a new watcher thread. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Bug: _ml_service_training_offloading_prepare_receiver() reassigned receiver_pipe with g_strdup() on each prepare call without freeing the previous string. Fix: clear receiver_pipe before storing the new pipeline description. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: MyungJoo Ham <myungjoo.ham@samsung.com>
cursor
bot
force-pushed
the
cursor/memory-leak-search-5f1f
branch
from
a1eccfa to
3059174
Compare
jaeyun-jung
approved these changes
Mar 17, 2026
cursor
bot
changed the title
cursor
bot
force-pushed
the
cursor/memory-leak-search-5f1f
branch
from
5fa7d4a to
3059174
Compare
myungjoo
changed the title
myungjoo
requested review from
again4you,
anyj0527,
gichan-jang and
songgot
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pipelinestring in_training_offloading_services_request()cleanup path_ml_service_training_offloading_process_received_data()received_threadbefore creating a new one in_training_offloading_check_received_data()receiver_pipebefore replacing it in_ml_service_training_offloading_prepare_receiver()libxml-2.0dependency whenenable-tizen-feature-checkis enabledpkgconfig(libxml-2.0)andlibxml2BuildRequires for Tizen feature-check builds-Wl,-rpath-link,<libxml2 libdir>propagation vianns_capi_common_depto resolve transitive xml2 dependencies (hal-api-common/pkgmgr-info) during unit-test linkingNotes
Validation
cursor/memory-leak-search-5f1f.