Move tools into implementors/node#19
Merged
legendecas merged 1 commit intonodejs:mainfrom Dec 12, 2025
Merged
Conversation
legendecas
approved these changes
Dec 12, 2025
github-project-automation
bot
moved this from Need Triage
to Done
in Node-API Team Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it would be better to move the tools introduced in #16 into the
implementors/nodedirectory, keeping the use of Node.js specific APIs contained.Merging this PR will:
strip.jsandloader.jsinto theimplementors/nodedirectory.ts-as they're both related to the ability to strip and load typescript.NODE_OPTIONSinto the workflow step'senvkey, as this impose less expectations on the shell used to run the script and is just more aligned with the intent of the workflow DSL.