Skip to content

fix(git-node): do not enforce minimum wait time for release proposals#1032

Open
aduh95 wants to merge 2 commits intonodejs:mainfrom
aduh95:no-minimal-wait-time-for-releases
Open

fix(git-node): do not enforce minimum wait time for release proposals#1032
aduh95 wants to merge 2 commits intonodejs:mainfrom
aduh95:no-minimal-wait-time-for-releases

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 3, 2026

AFAIK minimal wait time does not apply to release proposals, and in practice we do not delay releases if its proposal wasn't open for less than 48 hours, so it doesn't make sense to report insufficient time nor to check for fast-track labels. We also do not need approvals, but given that the bot opens the PR and the releaser can review it themself, it seems useful to still report lack of reviews as it's always better to do a sanity check on the release commit

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.94%. Comparing base (19b468a) to head (051915f).

Files with missing lines Patch % Lines
lib/pr_checker.js 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
- Coverage   80.98%   80.94%   -0.04%     
==========================================
  Files          39       39              
  Lines        4823     4829       +6     
==========================================
+ Hits         3906     3909       +3     
- Misses        917      920       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant