lib: Know when a process ended due to the child_process.spawn() timeout option #51561#51608
Open
FranciscoMateusVG wants to merge 3 commits intonodejs:mainfrom
Open
lib: Know when a process ended due to the child_process.spawn() timeout option #51561#51608FranciscoMateusVG wants to merge 3 commits intonodejs:mainfrom
FranciscoMateusVG wants to merge 3 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
child_process
aduh95
added
the
semver-minor
Contributor
|
/cc @nodejs/child_process |
|
Can someone review? |
Author
|
Wondering @RafaelGSS if there is someone i can call out to check this. Its being opened a while and there are some people still interested on this merge looking at this thread #51561 (comment) |
RafaelGSS
requested changes
Jan 24, 2026
Member
RafaelGSS
left a comment
RafaelGSS
left a comment
There was a problem hiding this comment.
I'm not on my computer right now - I can check this PR later. But, if you are certain we should have a new property on child, we must document it.
Document the timedOut boolean property on ChildProcess that indicates whether the child process was killed due to a timeout option. Refs: nodejs#51561
Author
|
@RafaelGSS done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: #51561
Having a way to know whether the process ended due to the timeout option by checking childProcess.timedOut = true