fs: Add support in globs for following (opt-in) symlinks#61162
Closed
MatricalDefunkt wants to merge 2 commits intonodejs:mainfrom
Closed
fs: Add support in globs for following (opt-in) symlinks#61162MatricalDefunkt wants to merge 2 commits intonodejs:mainfrom
MatricalDefunkt wants to merge 2 commits intonodejs:mainfrom
Conversation
Member
|
Can you fix linting and the commit format? |
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61162 +/- ##
==========================================
+ Coverage 88.52% 88.54% +0.01%
==========================================
Files 703 703
Lines 208589 208676 +87
Branches 40226 40247 +21
==========================================
+ Hits 184650 184765 +115
+ Misses 15954 15919 -35
- Partials 7985 7992 +7
π New features to boost your workflow:
|
Contributor
Author
Oops π¬ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for following symbolic links (symlinks) when performing glob operations in the filesystem module. It introduces a new
followSymlinksoption to relevant APIs, updates the documentation, and implements logic to safely traverse symlinks while preventing infinite loops due to cycles.The most important changes are:
API and Documentation Updates:
followSymlinksboolean option to the glob-related methods in the filesystem API, allowing users to specify whether symlinks to directories should be traversed. Documentation indoc/api/fs.mdhas been updated accordingly.Core Implementation in
lib/internal/fs/glob.js:Globclass and related functions to accept and handle thefollowSymlinksoption, including passing it to stat/lstat calls and ensuring symlinks are followed when requested.Internal Refactoring:
Fixes: #61033