-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
assert: fix loose deepEqual arrays with undefined and null failing #61587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
BridgeAR:BridgeAR/2026-01-30-fix-deep-equal
Feb 1, 2026
Merged
assert: fix loose deepEqual arrays with undefined and null failing #61587
nodejs-github-bot
merged 1 commit into
nodejs:main
from
BridgeAR:BridgeAR/2026-01-30-fix-deep-equal
Feb 1, 2026
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d8064f to
9d35d47
Compare
The comparison has to accept these as identical. Fixes: nodejs#61583
9d35d47 to
225a1fd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61587 +/- ##
==========================================
- Coverage 89.77% 89.76% -0.01%
==========================================
Files 673 673
Lines 203840 203841 +1
Branches 39180 39182 +2
==========================================
- Hits 182998 182983 -15
- Misses 13156 13188 +32
+ Partials 7686 7670 -16
🚀 New features to boost your workflow:
|
MrJithil
approved these changes
Jan 30, 2026
cjihrig
approved these changes
Jan 30, 2026
anonrig
approved these changes
Jan 30, 2026
ljharb
approved these changes
Jan 30, 2026
UlisesGascon
approved these changes
Jan 31, 2026
atlowChemi
approved these changes
Jan 31, 2026
Collaborator
Collaborator
Collaborator
|
Landed in 27a7bbc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparison has to accept these as identical.
Fixes: #61583