Skip to content

Conversation

@BridgeAR
Copy link
Member

The comparison has to accept these as identical.

Fixes: #61583

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jan 30, 2026
@BridgeAR BridgeAR marked this pull request as draft January 30, 2026 12:41
@BridgeAR BridgeAR force-pushed the BridgeAR/2026-01-30-fix-deep-equal branch from 3d8064f to 9d35d47 Compare January 30, 2026 12:43
The comparison has to accept these as identical.

Fixes: nodejs#61583
@BridgeAR BridgeAR force-pushed the BridgeAR/2026-01-30-fix-deep-equal branch from 9d35d47 to 225a1fd Compare January 30, 2026 12:50
@BridgeAR BridgeAR marked this pull request as ready for review January 30, 2026 12:50
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.76%. Comparing base (784ca7b) to head (225a1fd).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61587      +/-   ##
==========================================
- Coverage   89.77%   89.76%   -0.01%     
==========================================
  Files         673      673              
  Lines      203840   203841       +1     
  Branches    39180    39182       +2     
==========================================
- Hits       182998   182983      -15     
- Misses      13156    13188      +32     
+ Partials     7686     7670      -16     
Files with missing lines Coverage Δ
lib/internal/util/comparisons.js 99.71% <100.00%> (+<0.01%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@atlowChemi atlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 31, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2026
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@atlowChemi atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2026
@nodejs-github-bot nodejs-github-bot merged commit 27a7bbc into nodejs:main Feb 1, 2026
95 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 27a7bbc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

assert.deepEqual([null], [undefined]) behavior changed in v22.16.0 (undocumented breaking change)

8 participants