Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/internal/modules/cjs/loader.js
Original file line number Diff line number Diff line change
Expand Up @@ -1929,6 +1929,15 @@ Module._extensions['.js'] = function(module, filename) {
} else {
format = 'typescript';
}
} else if (path.extname(filename) === '') {
// Extensionless files skip the .js suffix check above. When type is explicit,
// follow it so ESM syntax surfaces as SyntaxError for commonjs instead of
// silently delegating to ESM.
pkg = packageJsonReader.getNearestParentPackageJSON(filename);
const typeFromPjson = pkg?.data?.type;
if (typeFromPjson === 'commonjs' || typeFromPjson === 'module') {
format = typeFromPjson;
}
}
const { source, format: loadedFormat } = loadSource(module, filename, format);
// Function require shouldn't be used in ES modules when require(esm) is disabled.
Expand Down
25 changes: 25 additions & 0 deletions test/es-module/test-extensionless-esm-type-commonjs.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
'use strict';

const { spawnSyncAndAssert } = require('../common/child_process');
const fixtures = require('../common/fixtures');

const commonjsDir = fixtures.path('es-modules', 'extensionless-esm-commonjs');

spawnSyncAndAssert(process.execPath, ['--no-experimental-detect-module', './script'], {
cwd: commonjsDir,
encoding: 'utf8',
}, {
status: 1,
stderr: /.+/,
trim: true,
});

const moduleDir = fixtures.path('es-modules', 'extensionless-esm-module');

spawnSyncAndAssert(process.execPath, ['--no-experimental-detect-module', './script'], {
cwd: moduleDir,
encoding: 'utf8',
}, {
stdout: /script STARTED[\s\S]*v\d+\./,
trim: true,
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"type": "commonjs"
}
4 changes: 4 additions & 0 deletions test/fixtures/es-modules/extensionless-esm-commonjs/script
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/usr/bin/env node
console.log('script STARTED')
import { version } from 'node:process'
console.log(version)
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"type": "module"
}
4 changes: 4 additions & 0 deletions test/fixtures/es-modules/extensionless-esm-module/script
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/usr/bin/env node
console.log('script STARTED')
import { version } from 'node:process'
console.log(version)