Skip to content

Conversation

@marco-ippolito
Copy link
Member

This PR makes --experimental-config-file accept no arg.
When no arg is passed, it will default to node.config.json.
--experimental-default-config-file is just an alias of --experimental-config-file.
The reason for this change is so when stable we can just remove --experimental-default-config-file and rename --experimental-config-file to --config-file.
Users can execute node with node --config-file index.js or node --config-file=foo.json index.js.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 1, 2026
@marco-ippolito marco-ippolito force-pushed the default-config-json branch 2 times, most recently from 775234b to 9b00ced Compare February 1, 2026 09:36
Copy link
Member

@pmarchini pmarchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmarchini pmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2026
@marco-ippolito marco-ippolito added the semver-minor PRs that contain new features and should be released in the next minor version. label Feb 1, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2026
@nodejs-github-bot
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.74%. Comparing base (f6464c5) to head (9b00ced).

Files with missing lines Patch % Lines
src/node_config_file.cc 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61610      +/-   ##
==========================================
- Coverage   89.76%   89.74%   -0.03%     
==========================================
  Files         673      673              
  Lines      203944   203954      +10     
  Branches    39191    39192       +1     
==========================================
- Hits       183080   183046      -34     
- Misses      13194    13234      +40     
- Partials     7670     7674       +4     
Files with missing lines Coverage Δ
lib/internal/process/pre_execution.js 95.84% <100.00%> (-0.13%) ⬇️
src/node_options.cc 76.32% <100.00%> (+0.04%) ⬆️
src/node_config_file.cc 82.54% <87.50%> (+0.59%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marco-ippolito marco-ippolito force-pushed the default-config-json branch 3 times, most recently from b9e1f93 to 3dc9b42 Compare February 1, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants