-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
src: allow empty --experimental-config-file #61610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marco-ippolito
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
marco-ippolito:default-config-json
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
775234b to
9b00ced
Compare
pmarchini
approved these changes
Feb 1, 2026
Member
pmarchini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MoLow
approved these changes
Feb 1, 2026
Collaborator
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61610 +/- ##
==========================================
- Coverage 89.76% 89.74% -0.03%
==========================================
Files 673 673
Lines 203944 203954 +10
Branches 39191 39192 +1
==========================================
- Hits 183080 183046 -34
- Misses 13194 13234 +40
- Partials 7670 7674 +4
🚀 New features to boost your workflow:
|
b9e1f93 to
3dc9b42
Compare
3dc9b42 to
2356e3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Issues and PRs that require attention from people who are familiar with C++.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
semver-minor
PRs that contain new features and should be released in the next minor version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
--experimental-config-fileaccept no arg.When no arg is passed, it will default to
node.config.json.--experimental-default-config-fileis just an alias of--experimental-config-file.The reason for this change is so when stable we can just remove
--experimental-default-config-fileand rename--experimental-config-fileto--config-file.Users can execute node with
node --config-file index.jsornode --config-file=foo.json index.js.