test: fix flaky test-performance-eventloopdelay #61629
Open
+40
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
test/sequential/test-performance-eventloopdelay.jsProblem
The test was flaky because the histogram sampling might not have completed
before the assertions ran. The assertion
assert(histogram.min > 0)couldfail if no samples were recorded yet.
Solution
setImmediate(common.mustCall(() => {...}))togive the event loop a chance to record final samples before checking
histogram.count > 0to provide a clearererror message if no samples are recorded
Verification
Verified with
python3 tools/test.py --repeat 50without failures.Refs: nodejs/reliability#1450