Skip to content

test: add describe abort signal tests#61711

Open
Han5991 wants to merge 1 commit intonodejs:mainfrom
Han5991:fix/test-runner-describe-abort
Open

test: add describe abort signal tests#61711
Han5991 wants to merge 1 commit intonodejs:mainfrom
Han5991:fix/test-runner-describe-abort

Conversation

@Han5991
Copy link
Contributor

@Han5991 Han5991 commented Feb 6, 2026

Summary

Adds tests to test/parallel/test-runner-misc.js to verify AbortSignal behavior in describe blocks.
This addresses the TODO comment: // TODO(benjamingr) add more tests to describe + AbortSignal.

Changes

  • Added test case for describe timeout triggering signal abort.
  • Added test case for manual abort in describe.
  • Verified signal propagation to nested tests.
  • Updated child process output assertions to match new test results (3 cancelled tests).

Verification

  • Run tools/test.py test/parallel/test-runner-misc.js

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 6, 2026
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.74%. Comparing base (9afa802) to head (89a9914).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #61711   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files         674      674           
  Lines      204424   204424           
  Branches    39287    39287           
=======================================
+ Hits       183464   183465    +1     
- Misses      13258    13262    +4     
+ Partials     7702     7697    -5     

see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Adds tests to verify AbortSignal behavior in describe blocks,
including timeout aborts, nested signal propagation, and
manual abort triggering.

Removes the TODO comment in test-runner-misc.js.
@Han5991 Han5991 force-pushed the fix/test-runner-describe-abort branch from 073b8ed to 89a9914 Compare February 6, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants