Skip to content

crypto: fix handling of null BUF_MEM* in ToV8Value() #61885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndossche wants to merge 4 commits into
base: main
Choose a base branch
from
+14 −1
Open

crypto: fix handling of null BUF_MEM* in ToV8Value() #61885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bd18e5
crypto: fix handling of null BUF_MEM* in ToV8Value()
ndossche Feb 19, 2026
5632d1f
fixup! Fix in more locations
ndossche Feb 19, 2026
56ed1f8
fixup! exception handling
ndossche Feb 24, 2026
44906b0
fixup! revert accidental change
ndossche Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/crypto/crypto_keys.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,15 @@ MaybeLocal<Value> ToV8Value(
Environment* env,
const BIOPointer& bio,
const EVPKeyPointer::AsymmetricKeyEncodingConfig& config) {
if (!bio) return {};
if (!bio) {
THROW_ERR_CRYPTO_OPERATION_FAILED(env, "Invalid BIO pointer");
return {};
}
BUF_MEM* bptr = bio;
if (!bptr) {
THROW_ERR_CRYPTO_OPERATION_FAILED(env, "Unable to create BUF_MEM pointer");
return {};
}
if (config.format == EVPKeyPointer::PKFormatType::PEM) {
// PEM is an ASCII format, so we will return it as a string.
return String::NewFromUtf8(
Expand Down
6 changes: 6 additions & 0 deletions src/crypto/crypto_x509.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ MaybeLocal<Value> ToV8Value(Local<Context> context, BIOPointer&& bio) {
if (!bio) [[unlikely]]
return {};
BUF_MEM* mem = bio;
if (!mem) [[unlikely]]
return {};
Local<Value> ret;
if (!String::NewFromUtf8(Isolate::GetCurrent(),
mem->data,
Expand All @@ -120,6 +122,8 @@ MaybeLocal<Value> ToV8Value(Local<Context> context, const BIOPointer& bio) {
if (!bio) [[unlikely]]
return {};
BUF_MEM* mem = bio;
if (!mem) [[unlikely]]
return {};
Local<Value> ret;
if (!String::NewFromUtf8(Isolate::GetCurrent(),
mem->data,
Expand All @@ -134,6 +138,8 @@ MaybeLocal<Value> ToBuffer(Environment* env, BIOPointer* bio) {
if (bio == nullptr || !*bio) [[unlikely]]
return {};
BUF_MEM* mem = *bio;
if (!mem) [[unlikely]]
return {};
#ifdef V8_ENABLE_SANDBOX
// If the v8 sandbox is enabled, then all array buffers must be allocated
// via the isolate. External buffers are not allowed. So, instead of wrapping
Expand Down
Loading