Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/modules/esm/get_format.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function detectModuleFormat(source, url) {
*/
function getDataProtocolModuleFormat(parsed) {
const { 1: mime } = RegExpPrototypeExec(
/^([^/]+\/[^;,]+)(?:[^,]*?)(;base64)?,/,
/^([^/]+\/[^;,]+)(?:;[^,]*)?,/,
parsed.pathname,
) || [ null, null, null ];

Expand Down
2 changes: 1 addition & 1 deletion lib/internal/modules/esm/load.js
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ function throwIfUnsupportedURLScheme(parsed) {
*/
function throwUnknownModuleFormat(url, format) {
const dataUrl = RegExpPrototypeExec(
/^data:([^/]+\/[^;,]+)(?:[^,]*?)(;base64)?,/,
/^data:([^/]+\/[^;,]+)(?:;[^,]*)?,/,
url,
);

Expand Down
19 changes: 19 additions & 0 deletions test/parallel/test-esm-data-url-format-regex-backtracking.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// Flags: --expose-internals
'use strict';

const common = require('../common');
const assert = require('assert');
const { defaultGetFormat } = require('internal/modules/esm/get_format');

// Regression test for #61904. This malformed data URL path is crafted to
// stress the MIME regex without triggering URL parsing failures.
const longPath = `data:a/${'a'.repeat(2 ** 17)}B`;
const start = process.hrtime.bigint();
const format = defaultGetFormat(new URL(longPath), { parentURL: undefined });
const elapsedMs = Number(process.hrtime.bigint() - start) / 1e6;

assert.strictEqual(format, null);
assert.ok(
elapsedMs < common.platformTimeout(1000),
`Expected format detection to complete quickly, took ${elapsedMs}ms`,
);