test_runner: make skip/todo/expectFailure use JS truthiness#62346
Open
VaishnavIUpadyaya wants to merge 4 commits intonodejs:mainfrom
Open
test_runner: make skip/todo/expectFailure use JS truthiness#62346VaishnavIUpadyaya wants to merge 4 commits intonodejs:mainfrom
VaishnavIUpadyaya wants to merge 4 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
atlowChemi
reviewed
Mar 20, 2026
atlowChemi
approved these changes
Mar 21, 2026
atlowChemi
approved these changes
Mar 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62346 +/- ##
==========================================
+ Coverage 89.65% 89.68% +0.02%
==========================================
Files 676 676
Lines 206555 206694 +139
Branches 39547 39577 +30
==========================================
+ Hits 185195 185377 +182
+ Misses 13495 13446 -49
- Partials 7865 7871 +6
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #61815
Updates skip, todo, and expectFailure handling in the test runner
to use JavaScript truthiness instead of explicit undefined/false checks.
This ensures:
Adds a test to verify that skip: '' does not skip the test.