Skip to content

doc: fix stray carriage return in packages.md#62350

Merged
Renegade334 merged 1 commit intonodejs:mainfrom
panva:stray-carriage-return
Mar 20, 2026
Merged

doc: fix stray carriage return in packages.md#62350
Renegade334 merged 1 commit intonodejs:mainfrom
panva:stray-carriage-return

Conversation

@panva
Copy link
Member

@panva panva commented Mar 20, 2026

@panva panva added the fast-track PRs that do not need to wait for 72 hours to land. label Mar 20, 2026
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@github-actions
Copy link
Contributor

Fast-track has been requested by @panva. Please πŸ‘ to approve.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 20, 2026
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very hard to spot, a shame GitHub UI nor the linter is able to help us catch that

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 20, 2026
Copy link
Member

@Renegade334 Renegade334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’ͺπŸͺŸ

Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ™

@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 20, 2026
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/62350
βœ”  Done loading data for nodejs/node/pull/62350
----------------------------------- PR info ------------------------------------
Title      doc: fix stray carriage return in packages.md (#62350)
Author     Filip Skokan <panva.ip@gmail.com> (@panva)
Branch     panva:stray-carriage-return -> nodejs:main
Labels     doc, fast-track
Commits    1
 - doc: fix stray carriage return in packages.md
Committers 1
 - Filip Skokan <panva.ip@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62350
Refs: https://openjs-foundation.slack.com/archives/C019Y2T6STH/p1774015976262609
Refs: https://github.com/nodejs/node/pull/62302
Refs: https://github.com/nodejs/node/actions/runs/23347139396/job/67915524762?pr=61767
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: RenΓ© <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62350
Refs: https://openjs-foundation.slack.com/archives/C019Y2T6STH/p1774015976262609
Refs: https://github.com/nodejs/node/pull/62302
Refs: https://github.com/nodejs/node/actions/runs/23347139396/job/67915524762?pr=61767
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: RenΓ© <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
--------------------------------------------------------------------------------
   β„Ή  This PR was created on Fri, 20 Mar 2026 14:26:56 GMT
   βœ”  Approvals: 5
   βœ”  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/62350#pullrequestreview-3981907555
   βœ”  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/62350#pullrequestreview-3982025863
   βœ”  - RenΓ© (@Renegade334): https://github.com/nodejs/node/pull/62350#pullrequestreview-3982152226
   βœ”  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/62350#pullrequestreview-3982194999
   βœ”  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/62350#pullrequestreview-3982214292
   β„Ή  This PR is being fast-tracked
   βœ”  Last GitHub CI successful
   β„Ή  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   βœ”  No git cherry-pick in progress
   βœ”  No git am in progress
   βœ”  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
βœ”  origin/main is now up-to-date
- Downloading patch for 62350
From https://github.com/nodejs/node
 * branch                  refs/pull/62350/merge -> FETCH_HEAD
βœ”  Fetched commits as 052aec7127f4..385a91a55f03
--------------------------------------------------------------------------------
[main ba5c2fd55c] doc: fix stray carriage return in packages.md
 Author: Filip Skokan <panva.ip@gmail.com>
 Date: Fri Mar 20 15:14:17 2026 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
   βœ”  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
doc: fix stray carriage return in packages.md

PR-URL: #62350
Refs: https://openjs-foundation.slack.com/archives/C019Y2T6STH/p1774015976262609
Refs: #62302
Refs: https://github.com/nodejs/node/actions/runs/23347139396/job/67915524762?pr=61767
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: RenΓ© <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>

[main f70e40c0a8] doc: fix stray carriage return in packages.md
Author: Filip Skokan <panva.ip@gmail.com>
Date: Fri Mar 20 15:14:17 2026 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
βœ” f70e40c0a80b6aebef212d34640d9fcad4d1f21d
βœ” 0:0 no Co-authored-by metadata co-authored-by-is-trailer
βœ” 0:0 skipping fixes-url fixes-url
βœ” 0:0 blank line after title line-after-title
βœ” 0:0 line-lengths are valid line-length
βœ” 0:0 metadata is at end of message metadata-end
βœ” 1:8 PR-URL is valid. pr-url
βœ” 0:0 reviewers are valid reviewers
βœ” 0:0 valid subsystems subsystem
βœ” 0:0 Title is formatted correctly. title-format
βœ” 0:0 Title is <= 50 columns. title-length

The following commits are ready to be pushed to origin/main

  • f70e40c0a8 doc: fix stray carriage return in packages.md

Temporary files removed.
To finish landing:

  1. Run:
    git push origin main
  2. Post "Landed in f70e40c0a80b" in doc: fix stray carriage return in packages.mdΒ #62350
    gh pr comment doc: fix stray carriage return in packages.mdΒ #62350 --body "Landed in f70e40c0a80b"
    gh pr close doc: fix stray carriage return in packages.mdΒ #62350
https://github.com/nodejs/node/actions/runs/23351358101

@Renegade334 Renegade334 merged commit b2c5235 into nodejs:main Mar 20, 2026
33 of 34 checks passed
@Renegade334
Copy link
Member

Landed (kicking and screaming) in b2c5235

@Renegade334 Renegade334 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants