Skip to content

feat(i18n): add Arabic font support#1511

Open
abaza738 wants to merge 2 commits intonpmx-dev:mainfrom
abaza738:main
Open

feat(i18n): add Arabic font support#1511
abaza738 wants to merge 2 commits intonpmx-dev:mainfrom
abaza738:main

Conversation

@abaza738
Copy link
Contributor

Added a font for Arabic language because the current font does not support Arabic letters (and I guess many other languages?)😅.
Tested this locally and found it to preserve the original font Geist when English text is written in the middle of Arabic text, I suppose this is unicode-range working properly.

@vercel
Copy link

vercel bot commented Feb 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Mar 22, 2026 5:14am
npmx.dev Ready Ready Preview, Comment Mar 22, 2026 5:14am
npmx.dev (canary) Ready Ready Preview, Comment Mar 22, 2026 5:14am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Mar 22, 2026 5:14am

Request Review

@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 14, 2026

📝 Walkthrough

Walkthrough

The change adds "IBM Plex Sans Arabic" to font stacks and configuration only. In lunaria/styles.ts the root CSS variables --ln-font-body and --ln-font-mono are extended to include "IBM Plex Sans Arabic". nuxt.config.ts gains a fonts.families entry for "IBM Plex Sans Arabic" with weights 400, 500, 600, global rendering enabled and the Arabic subset. uno.config.ts updates theme.font.mono and theme.font.sans to include "IBM Plex Sans Arabic". No other logic was changed.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset, which adds Arabic font support (IBM Plex Sans Arabic) across three configuration files to enable proper rendering of Arabic text.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you show some screenshots of before/after? @abaza738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale This has become stale and may be closed soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants