Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #2049
🧭 Context
Some warnings shown in the skills modal and diff sidebar were previously hardcoded English strings produced on the server.
This change localizes those warnings by returning structured warning messages with translation keys, then translating them in the UI through a shared composable.
📚 Description
Changes:
WarningMessagetype for structured warningsuseI18nWarning()I went back and forth a bit on whether these warnings should remain entirely client-derived, since there are already places in the project where warning-like UI text is built on the frontend.
Following the discussion in #2049 with @ShroXd, it felt worthwhile to establish this pattern here: it not only improves i18n handling, but also gives us a clearer structure for information flow, while translation keys remain semantic and readable.
So this PR also serves as an experiment to explore what this direction would look like in practice.
One thing to note is that this also introduces a dynamic key mechanism that isn't currently accepted by the existing i18n validation.