feat(ui): improve compare types in FacetRow for CLI package#690
Merged
danielroe merged 4 commits intonpmx-dev:mainfrom Feb 2, 2026
Merged
Conversation
- fix tooltips in FacetRow - add 'muted' status option with text-fg-subtle styling - show types as "N/A" with muted style for binary-only packages - move binary detection utils to shared/utils for reuse - use Packument type for registry API responses
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
Author
|
serhalp
approved these changes
Feb 2, 2026
| } | ||
|
|
||
| case 'types': | ||
| if (data.isBinaryOnly) { |
Member
There was a problem hiding this comment.
Could we add a tooltip on the 'N/A' with a line explaining why it's N/A? something like "This package exposes binaries and no exports"
…compare-types-for-CLI-pkg # Conflicts: # app/components/compare/FacetRow.vue
danielroe
approved these changes
Feb 2, 2026
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
taskylizard
pushed a commit
to taskylizard/npmx.dev
that referenced
this pull request
Feb 7, 2026
…#690) Co-authored-by: Yevhen Husak <gusa4grr@users.noreply.github.com> Co-authored-by: Daniel Roe <daniel@roe.dev> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #631