Skip to content

refactor: extract more vscode-independent logic to language-core#84

Merged
9romise merged 2 commits intomainfrom
language-core
Mar 21, 2026
Merged

refactor: extract more vscode-independent logic to language-core#84
9romise merged 2 commits intomainfrom
language-core

Conversation

@9romise
Copy link
Member

@9romise 9romise commented Mar 21, 2026

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4344a60b-7726-41f8-afd8-998e21832b01

📥 Commits

Reviewing files that changed from the base of the PR and between 8a4ce80 and 3550942.

📒 Files selected for processing (2)
  • extensions/vscode/src/providers/diagnostics/index.ts
  • extensions/vscode/src/providers/hover/resolve.ts
✅ Files skipped from review due to trivial changes (1)
  • extensions/vscode/src/providers/diagnostics/index.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • extensions/vscode/src/providers/hover/resolve.ts

📝 Walkthrough

Walkthrough

This PR extracts many utilities, types and constants from the VS Code extension into a new package packages/language-core, adds new public entrypoints in that package's package.json, and updates the extension to import those relocated symbols from npmx-language-core/*. Moved/added pieces include file-path predicates (isDependencyFile, isPackageManifest, isWorkspaceFile), package helpers (encodePackageName, resolveExactVersion), constants (CACHE_MAX_AGE_ONE_DAY, NPMX_DEV, NPMX_DEV_API), and link/API modules. The extension removes several local helpers/tests and switches callers to the language-core implementations; several language-core APIs also have logging side-effect removals and tsdown/packaging adjustments.

Possibly related PRs

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request has no description provided by the author, making it impossible to assess whether the intent is communicated clearly. Add a descriptive pull request description explaining the refactoring goals, changes made, and any migration notes for maintainers reviewing this extraction of vscode-independent logic.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch language-core

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as resolved.

@9romise 9romise added this pull request to the merge queue Mar 21, 2026
Merged via the queue into main with commit f09aa27 Mar 21, 2026
11 checks passed
@9romise 9romise deleted the language-core branch March 21, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant