Merged
Conversation
carpawell
requested review from
End-rey,
cthulhu-rider and
roman-khimov
as code owners
carpawell
force-pushed
the
feat/allow-split-of-the-split
branch
from
8538867 to
3295adf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3867 +/- ##
=======================================
Coverage 26.08% 26.09%
=======================================
Files 675 675
Lines 43638 43638
=======================================
+ Hits 11385 11388 +3
+ Misses 31195 31193 -2
+ Partials 1058 1057 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
carpawell
force-pushed
the
feat/allow-split-of-the-split
branch
from
3295adf to
679b5b3
Compare
Contributor
cthulhu-rider
left a comment
cthulhu-rider
left a comment
There was a problem hiding this comment.
i think it's worth limiting the nesting levels similar to metabase for early failure
CHANGELOG.md
Outdated
| - Move lens `write-cache` `get`/`list` commands into `fstree` section in CLI (#3838, #3844) | ||
| - Session key storage access session keys by account only (#3817) | ||
| - Optimized locking for reputation data collector (#3851) | ||
| - Split of a split is now allowed for regular (non-EC) placement policies (#3867) |
Contributor
There was a problem hiding this comment.
Suggested change
| - Split of a split is now allowed for regular (non-EC) placement policies (#3867) | |
| - Split of a split is now allowed for REP policies (#3867) |
EC is out of context here
Member
There was a problem hiding this comment.
We need it for EC anyway, so better check and drop REP/EC references completely.
Member
Author
There was a problem hiding this comment.
i am not sure i understood your worries, let it be in Fixed then?
carpawell
force-pushed
the
feat/allow-split-of-the-split
branch
from
679b5b3 to
c6ec2b5
Compare
Member
Author
Done |
roman-khimov
approved these changes
Mar 10, 2026
Member
|
Conflicts. |
carpawell
force-pushed
the
feat/allow-split-of-the-split
branch
from
c6ec2b5 to
b95ac48
Compare
Member
|
Tests fail here. |
carpawell
force-pushed
the
feat/allow-split-of-the-split
branch
from
b95ac48 to
1baa2a7
Compare
Member
|
Conflicts |
This is essentially means reverting of 60faa73, and verifying LINK objects considering complex parents as a normal situation. Split of a split is now have a use case in s3-gw's multipart code. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
force-pushed
the
feat/allow-split-of-the-split
branch
from
1baa2a7 to
32c7dc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essentially means reverting of 60faa73,
and verifying LINK objects considering complex parents as a normal situation.
Split of a split is now have a use case in s3-gw's multipart code.