morph: adopt neorpc.GASLimitExceededException#3868
Open
AnnaShaleva wants to merge 2 commits intomasterfrom
Open
morph: adopt neorpc.GASLimitExceededException#3868AnnaShaleva wants to merge 2 commits intomasterfrom
neorpc.GASLimitExceededException#3868AnnaShaleva wants to merge 2 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3868 +/- ##
==========================================
+ Coverage 26.02% 26.03% +0.01%
==========================================
Files 675 675
Lines 43760 43751 -9
==========================================
+ Hits 11388 11391 +3
+ Misses 31315 31303 -12
Partials 1057 1057 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AnnaShaleva
force-pushed
the
fetch-gas-limit-exceeded
branch
from
81d2ac1 to
f66a6fc
Compare
AnnaShaleva
commented
Mar 13, 2026
| err := invokeFunc() | ||
| if err != nil { | ||
| if errors.Is(err, neorpc.ErrMempoolCapReached) || insufficientAmountOfGasErr(err) { | ||
| if errors.Is(err, neorpc.ErrMempoolCapReached) || errors.Is(&neorpc.FaultException{Message: err.Error()}, neorpc.GASLimitExceededException) { |
Member
Author
There was a problem hiding this comment.
@roman-khimov, ref. nspcc-dev/neo-go#4189 (comment), just a note: originally I added neorpc.FaultException constructor to avoid such things on the client side.
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
fetch-gas-limit-exceeded
branch
from
f66a6fc to
57cccc3
Compare
AnnaShaleva
added
dependencies
AnnaShaleva
requested review from
End-rey,
carpawell and
cthulhu-rider
as code owners
AnnaShaleva
changed the title
neorpc.GASLimitExceededException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port nspcc-dev/neo-go#4189. Ref. #3839.
Blocked by NeoGo release. All NeoFS nodes upgrade should happen before the compatibility code removal.