chore: linting and static checks for pynumaflow-lite#346
Conversation
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 67 67
Lines 3513 3513
Branches 229 229
=======================================
Hits 3256 3256
Misses 193 193
Partials 64 64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| flushing sorted data when the watermark advances. | ||
| """ | ||
|
|
||
| import signal |
There was a problem hiding this comment.
review requested
manual change: import moved to the top
| from . import pynumaflow_lite # type: ignore[attr-defined] # Rust extension, resolved at runtime | ||
| from .pynumaflow_lite import * # noqa: F403 # Rust extension; exports resolved at runtime |
There was a problem hiding this comment.
review requested
manual change:
- warning suppression for imports
- explicitly import
from . import pynumaflow_lite
| def __getattr__(name: str) -> _typeshed.Incomplete: ... | ||
|
|
There was a problem hiding this comment.
review requested
manual change: moved after imports
|
|
||
| import signal |
There was a problem hiding this comment.
review requested
manual change: import moved to the top
| py-fmt: | ||
| uv run black pynumaflow_lite/ tests/ manifests/ | ||
|
|
||
| py-lint: py-fmt | ||
| uv run ruff check --fix . | ||
|
|
||
| fmt: | ||
| cargo fmt --all | ||
|
|
||
| .PHONY: lint | ||
| lint: test-fmt clippy | ||
| lint: test-fmt clippy py-lint |
There was a problem hiding this comment.
review requested
manual change: makefile lint command updated to include python linting
| "black>=24.8.0", | ||
| "pytest>=8.3.5", | ||
| "ruff>=0.15.8", |
There was a problem hiding this comment.
review requested
manual change: These packages were added as dev dependencies for python linting
vaibhavtiwari33
changed the title
vaibhavtiwari33
requested review from
BulkBeing,
kohlisid and
vigith
as code owners
2 participants
I'll mark where I've made manual changes to fix issues flagged by the ruff analyzer, rest all are fixed by the formatter.