[BUG]: Avoiding promoter overrides leading to global state corruption#78
Open
SwayamInSync wants to merge 4 commits intonumpy:mainfrom
Open
[BUG]: Avoiding promoter overrides leading to global state corruption#78SwayamInSync wants to merge 4 commits intonumpy:mainfrom
SwayamInSync wants to merge 4 commits intonumpy:mainfrom
Conversation
seberg
reviewed
Mar 28, 2026
Member
seberg
left a comment
seberg
left a comment
There was a problem hiding this comment.
Thanks, LGTM, but the ld promoter doesn't really look right. I.e. it doesn't do anything interesting?
To be fair, that seems like an existing bug...
src/include/umath/promoters.hpp
Outdated
|
|
||
| // Preserve the integer type for the exponent (slot 1) | ||
| Py_INCREF(op_dtypes[1]); | ||
| new_op_dtypes[1] = op_dtypes[1]; |
Member
There was a problem hiding this comment.
you want to promote to PyArray_PyLongDType here. (assuming signature[1] == NULL).
(I guess you could add more logic in case of non-ints, but maybe doesn't matter much in practice... cast safety may even reject it normally anyway.)
Although long seems weird compared to just using intp that always works, but OK. Otherwise this looks like it doesn't do anything really.
Member
Author
There was a problem hiding this comment.
Right, I updated the loop registration + promoter to use intp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #76